qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-1354) Disable problematic SASL mechanisms if they are not explicitly enabled
Date Tue, 19 Jun 2018 14:54:00 GMT

    [ https://issues.apache.org/jira/browse/PROTON-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16517189#comment-16517189
] 

ASF GitHub Bot commented on PROTON-1354:
----------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/qpid-proton/pull/148
  
    # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/148?src=pr&el=h1) Report
    > Merging [#148](https://codecov.io/gh/apache/qpid-proton/pull/148?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/qpid-proton/commit/885d68aeaf522021a35b7b5cecb7c7c53663929b?src=pr&el=desc)
will **increase** coverage by `<.01%`.
    > The diff coverage is `83.33%`.
    
    [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-proton/pull/148/graphs/tree.svg?width=650&token=UKKzV9XnFF&height=150&src=pr)](https://codecov.io/gh/apache/qpid-proton/pull/148?src=pr&el=tree)
    
    ```diff
    @@            Coverage Diff            @@
    ##           master    #148      +/-   ##
    =========================================
    + Coverage    86.5%   86.5%   +<.01%     
    =========================================
      Files         247     247              
      Lines       30397   30402       +5     
    =========================================
    + Hits        26294   26299       +5     
      Misses       4103    4103
    ```
    
    
    | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/148?src=pr&el=tree)
| Coverage Δ | |
    |---|---|---|
    | [c/src/sasl/sasl.c](https://codecov.io/gh/apache/qpid-proton/pull/148/diff?src=pr&el=tree#diff-Yy9zcmMvc2FzbC9zYXNsLmM=)
| `86.66% <83.33%> (+0.14%)` | :arrow_up: |
    
    ------
    
    [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/148?src=pr&el=continue).
    > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
    > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
    > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/148?src=pr&el=footer).
Last update [885d68a...1413b78](https://codecov.io/gh/apache/qpid-proton/pull/148?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



> Disable problematic SASL mechanisms if they are not explicitly enabled
> ----------------------------------------------------------------------
>
>                 Key: PROTON-1354
>                 URL: https://issues.apache.org/jira/browse/PROTON-1354
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: proton-c
>            Reporter: Justin Ross
>            Assignee: Andrew Stitcher
>            Priority: Major
>              Labels: sasl, usability
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message