qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DISPATCH-976) Allow policy for sources and targets to handle multiple wildcards
Date Wed, 13 Jun 2018 02:14:00 GMT

    [ https://issues.apache.org/jira/browse/DISPATCH-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16510526#comment-16510526
] 

ASF GitHub Bot commented on DISPATCH-976:
-----------------------------------------

Github user fgiorgetti commented on the issue:

    https://github.com/apache/qpid-dispatch/pull/324
  
    @ganeshmurthy and @ChugR after debugging it a little bit more, I noticed that the first
if statement that checks for an absent user key in the iterating allowed address, was also
checking the "need_check_nosubst" boolean, enforcing that only one address with "absent" user
key is defined.
    So with this boolean flag, in case more than one address is defined in the tree (without
the user key), it  causes the last "else" statement to be processed and then executing the
"assert(false);" which was crashing the router.
    In this PR I have removed the need_check_nosubst flag which seems to resolve the issue
reported in DISPATCH-1026 as well.


> Allow policy for sources and targets to handle multiple wildcards
> -----------------------------------------------------------------
>
>                 Key: DISPATCH-976
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-976
>             Project: Qpid Dispatch
>          Issue Type: Bug
>          Components: Policy Engine
>    Affects Versions: 1.0.1
>            Reporter: Chuck Rolke
>            Assignee: Chuck Rolke
>            Priority: Major
>             Fix For: 1.2.0
>
>
> As per the [upstream policy documentation|https://github.com/apache/qpid-dispatch/blob/1.0.0/doc/book/policy.adoc]
in the secion on [AMQP Source and Target Wildcard and Name Substitution|https://github.com/apache/qpid-dispatch/blob/1.0.0/doc/book/policy.adoc#amqp-source-and-target-wildcard-and-name-substitution]
utilization of the asterisk wildcard is constrained as per the following quote:
> {quote}The asterisk is recognized only if it is the last character in the link name.
> {quote}
> It is desirable that the configuration could handle a situation where there are multiple
asterisks in use such as:
>  
> |{color:#000000}"tstGroup": {{color}|
> |{color:#000000} "users": "tst@amq",{color}|
> |{color:#000000} "sources": "abc.*,my.*.b2b.tst.*",{color}|
> |{color:#000000} "targets": "abc.*,my.*.b2b.tst.*",{color}|
> |{color:#000000} "remoteHosts": "*"{color}|
> |{color:#000000}} {color}|
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message