qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DISPATCH-1045) Sometimes close connetion after releasing partial multi-frame messsage
Date Fri, 22 Jun 2018 20:04:00 GMT

    [ https://issues.apache.org/jira/browse/DISPATCH-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520737#comment-16520737
] 

ASF GitHub Bot commented on DISPATCH-1045:
------------------------------------------

GitHub user ganeshmurthy opened a pull request:

    https://github.com/apache/qpid-dispatch/pull/328

    DISPATCH-1045 - Release the delivery only after the entire message ha…

    …s been received

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1045

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-dispatch/pull/328.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #328
    
----
commit e40858d7da687e427d624409ba60cb27c1fe0550
Author: Ganesh Murthy <gmurthy@...>
Date:   2018-06-22T20:01:51Z

    DISPATCH-1045 - Release the delivery only after the entire message has been received

----


> Sometimes close connetion after releasing partial multi-frame messsage
> ----------------------------------------------------------------------
>
>                 Key: DISPATCH-1045
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1045
>             Project: Qpid Dispatch
>          Issue Type: Bug
>          Components: Router Node
>    Affects Versions: 1.1.0
>            Reporter: Alan Conway
>            Assignee: Ganesh Murthy
>            Priority: Major
>
> Since DISPATCH-1012 the router releases undeliverable deliveries.
> In the case of a multi-frame delivery, it is possible for dispatch to release it before
the entire delivery has been received. Presently dispatch settles such deliveries and advances
its link. That means that if another transfer for the same delivery arrives, dispatch regards
it as a new message with an invalid delivery-id and closes the connection. Since the release
is asynchronous, there's no way for the client to avoid this possibility.
> Worth checking the spec but I suspect we should be dropping the extra data rather than
closing the connection. Need to investigate how this would work in proton - I think we'd update
the delivery without settling it and then wait for the remote to settle before finally throwing
it away.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message