qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alex-rufous <...@git.apache.org>
Subject [GitHub] qpid-broker-j pull request #7: QPID-7541: [Broker-J] Close Consumers when a ...
Date Fri, 01 Jun 2018 22:41:22 GMT
GitHub user alex-rufous opened a pull request:

    https://github.com/apache/qpid-broker-j/pull/7

    QPID-7541: [Broker-J] Close Consumers when a Queue is deleted

    Following discussion in user mailing list [What is AMQP 1-0 spec complaint Broker behaviour
for deletion of queue with consumers attached?](https://lists.apache.org/thread.html/3e64db4411925250b02e3f4648263a648c4406f1bbcb342369eeb06a@%3Cusers.qpid.apache.org%3E)
I implemented changes allowing to detach links on queue or exchange deletion if environment
variable `qpid.resource.deleteOnlyWithNoLinkAttached` is set to `false`. If it is set to `true`,
the queue/exchange cannot be deleted with any  associated sending or receiving links.
    
    When`qpid.resource.deleteOnlyWithNoLinkAttached=false` the following behaviour is implemented:
    * detaches all links with an error "amqp:resource-deleted"
    * any in-progress producing/consuming transactions are marked as rollback-only
    * if commit/rollback is in progress and transaction cannot be marked as rollback-only,
the deletion waits for discharge to finish
    * the remaining messages on the deleted queue are moved alternate binding if one is configured


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alex-rufous/qpid-broker-j master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-broker-j/pull/7.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #7
    
----
commit 6b16be0b3a76adf6d1d647c69881e73146e5c9e8
Author: Alex Rudyy <orudyy@...>
Date:   2018-05-30T10:49:07Z

    QPID-7541: [Broker-J] Prevent deletion of queues and exchanges with attached links

commit ee55830b729b4b8794cee35b7020cae3bc41a555
Author: Alex Rudyy <orudyy@...>
Date:   2018-06-01T16:55:12Z

    QPID-7541: [Broker-J] Detach links on destination deletion

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message