qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DISPATCH-1008) Router should preserve original connection information when attempting to make failover connections
Date Tue, 31 Jul 2018 18:03:00 GMT

    [ https://issues.apache.org/jira/browse/DISPATCH-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564081#comment-16564081
] 

ASF GitHub Bot commented on DISPATCH-1008:
------------------------------------------

GitHub user ganeshmurthy opened a pull request:

    https://github.com/apache/qpid-dispatch/pull/348

    DISPATCH-1008 - Back out previous change that was storing every failo…

    …ver url obtained from every connection. Modified the code to wipe out the failover
urls obtained from the previous connection if the current connection returned an empty list
for failover urls

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1008-3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-dispatch/pull/348.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #348
    
----
commit 8d12f277c8cb120731ba956da791d8828692702a
Author: Ganesh Murthy <gmurthy@...>
Date:   2018-07-12T18:56:10Z

    DISPATCH-1008 - Back out previous change that was storing every failover url obtained
from every connection. Modified the code to wipe out the failover urls obtained from the previous
connection if the current connection returned an empty list for failover urls

----


> Router should preserve original connection information when attempting to make failover
connections
> ---------------------------------------------------------------------------------------------------
>
>                 Key: DISPATCH-1008
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1008
>             Project: Qpid Dispatch
>          Issue Type: Bug
>            Reporter: Ganesh Murthy
>            Assignee: Ganesh Murthy
>            Priority: Major
>             Fix For: 1.2.0
>
>         Attachments: broker-slave.xml, broker.xml, qdrouterd-failover.conf
>
>
> # Start artemis master and slave brokers and the router with the attached config files.
>  # Notice that the router receives an open frame from the master broker with the following
failover information
>  # 
> {noformat}
> 2018-05-22 22:11:11.830106 -0230 SERVER (trace) [1]:0 <- @open(16) [container-id="localhost",
max-frame-size=4294967295, channel-max=65535, idle-time-out=30000, offered-capabilities=@PN_SYMBOL[:"sole-connection-for-container",
:"DELAYED_DELIVERY", :"SHARED-SUBS", :"ANONYMOUS-RELAY"], properties={:product="apache-activemq-artemis",
:"failover-server-list"=[{:hostname="0.0.0.8", :scheme="amqp", :port=61617, :"network-host"="0.0.0.0"}]"}]{noformat}
>  
>  # Now, kill the master broker and notice that the router correctly fails over to the
slave broker. But the slave broker does not provide any failover information in its open frame
and hence the router erases its original master broker connection information
>  # When the master broker is now restarted and the slave broker is killed, the router
attempts to repeatedly connect only to the slave broker but never attempts a connection to
the master broker.
>  # If the router did not erase its failover list but preserved the original master connection
information, it would have connected the master broker.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message