qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-8208) [Broker-J] Improve handling of unexpected exceptions on establishing LDAP connections in SimpleLDAPAuthenticationProvider
Date Fri, 06 Jul 2018 08:18:00 GMT

    [ https://issues.apache.org/jira/browse/QPID-8208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534560#comment-16534560

ASF GitHub Bot commented on QPID-8208:

Github user alex-rufous commented on a diff in the pull request:

    --- Diff: broker-plugins/jdbc-store/src/main/java/org/apache/qpid/server/store/jdbc/JDBCDetails.java
    @@ -379,7 +403,8 @@ public boolean isOverridden()
                     return contextMap.containsKey(CONTEXT_JDBCSTORE_USEBYTESFORBLOB)
                             || contextMap.containsKey(CONTEXT_JDBCSTORE_BIGINTTYPE)
                             || contextMap.containsKey(CONTEXT_JDBCSTORE_VARBINARYTYPE)
    -                        || contextMap.containsKey(CONTEXT_JDBCSTORE_BLOBTYPE);
    +                        || contextMap.containsKey(CONTEXT_JDBCSTORE_BLOBTYPE)
    --- End diff --
    My apologies. Please ignore my comment. I overlooked method name

> [Broker-J] Improve handling of unexpected exceptions  on establishing LDAP connections
in SimpleLDAPAuthenticationProvider
> --------------------------------------------------------------------------------------------------------------------------
>                 Key: QPID-8208
>                 URL: https://issues.apache.org/jira/browse/QPID-8208
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Broker-J
>    Affects Versions: qpid-java-6.1.6, qpid-java-broker-7.0.3, qpid-java-broker-7.0.2,
0.32, qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2, qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5,
qpid-java-6.1, qpid-java-6.0.6, qpid-java-6.1.1, qpid-java-6.1.2, qpid-java-6.0.7, qpid-java-6.1.3,
qpid-java-6.0.8, qpid-java-6.1.4, qpid-java-broker-7.0.0, qpid-java-6.1.5, qpid-java-broker-7.0.1,
>            Reporter: Alex Rudyy
>            Priority: Critical
> There is a weakness in Qpid exception handling when communication with external services
like LDAP. The Broker should take a more defensive approach and handle unexpected exceptions
thrown by underlying third-party API in addition to exceptions declared in API interfaces.
The unexpected exceptions thrown by underlying API should not affect the stability of the
> It was reported that on establishment of connection with LDAP using default context factory
{{com.sun.jndi.ldap.LdapCtxFactory}} the creation of  {{InitialDirContext}} can end-up in
unexpected exception thrown from {{com.sun.jndi.ldap.LdapClient}}. It looks like a defect
in {{com.sun.jndi.ldap.LdapClient}}, but I could not find any existing open bug report raised
against JVM with similar behaviour. I think that Broker should catch unexpected exception,
log it and report authentication failure back to the client.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

View raw message