qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DISPATCH-1055) Flow credit not propagated over link route after drain cycle
Date Wed, 11 Jul 2018 13:01:00 GMT

    [ https://issues.apache.org/jira/browse/DISPATCH-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540075#comment-16540075
] 

ASF subversion and git services commented on DISPATCH-1055:
-----------------------------------------------------------

Commit a6c4b94b87f4b11981b1a549ddee6f614ee6e0a3 in qpid-dispatch's branch refs/heads/master
from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=a6c4b94 ]

DISPATCH-1055: Fix credit propagation over link route after drain cycle

Reset incremental credit given to core at end of drain cycle.
Fix logic computing drain_changed flag.

This closes #340


> Flow credit not propagated over link route after drain cycle
> ------------------------------------------------------------
>
>                 Key: DISPATCH-1055
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1055
>             Project: Qpid Dispatch
>          Issue Type: Bug
>          Components: Router Node
>    Affects Versions: 1.1.0
>            Reporter: Chuck Rolke
>            Priority: Major
>         Attachments: D-2004-direct.html, D-2004-routed.html
>
>
> A transaction test based on activemq-artemis TransactionTest reveals a credit propagation
bug. The original case and reproducer code is at [https://issues.jboss.org/browse/ENTMQIC-2004]
>  
> Attached are two traces of the test running direct and routed. I think this is a router
bug.
>  * In the direct case (D-2004-direct.html) look at Frames 101-103. Frame 101 starts a
drain cycle and Frame 102 complete the drain cycle. The the client in Frame 103 immediately
sends the receiver 1000 more credits.
>  * In the routed case (D-2004-routed.html) the same sequence is Frames 90-94. Frame 90
(client->router) and Frame 91 (router->broker) start the drain cycle. Frame 92 (broker->router)
and Frame 93 (router->client) complete the drain cycle. Then in Frame 94 the client sends
1000 more credits but the router never sends the credits to the broker. That is the bug.
> After Frame 94, where the router does not send any receiver credits to the broker, the
broker is unable to send any received messages to the receiver and everything freezes until
the test times out.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message