qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-1888) Allow configuration of connection details via a simple config file
Date Mon, 09 Jul 2018 21:02:00 GMT

    [ https://issues.apache.org/jira/browse/PROTON-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16537569#comment-16537569
] 

ASF GitHub Bot commented on PROTON-1888:
----------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/qpid-proton/pull/150
  
    # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/150?src=pr&el=h1) Report
    > Merging [#150](https://codecov.io/gh/apache/qpid-proton/pull/150?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/qpid-proton/commit/252451f0ad06e6f29c6eb424ba31ead5e4b53545?src=pr&el=desc)
will **increase** coverage by `0.09%`.
    > The diff coverage is `97.26%`.
    
    [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-proton/pull/150/graphs/tree.svg?width=650&src=pr&token=UKKzV9XnFF&height=150)](https://codecov.io/gh/apache/qpid-proton/pull/150?src=pr&el=tree)
    
    ```diff
    @@            Coverage Diff            @@
    ##           master    #150      +/-   ##
    =========================================
    + Coverage   86.51%   86.6%   +0.09%     
    =========================================
      Files         247     248       +1     
      Lines       30443   30589     +146     
    =========================================
    + Hits        26337   26493     +156     
    + Misses       4106    4096      -10
    ```
    
    
    | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/150?src=pr&el=tree)
| Coverage Δ | |
    |---|---|---|
    | [python/tests/proton\_tests/\_\_init\_\_.py](https://codecov.io/gh/apache/qpid-proton/pull/150/diff?src=pr&el=tree#diff-cHl0aG9uL3Rlc3RzL3Byb3Rvbl90ZXN0cy9fX2luaXRfXy5weQ==)
| `100% <100%> (ø)` | :arrow_up: |
    | [python/tests/proton\_tests/connect.py](https://codecov.io/gh/apache/qpid-proton/pull/150/diff?src=pr&el=tree#diff-cHl0aG9uL3Rlc3RzL3Byb3Rvbl90ZXN0cy9jb25uZWN0LnB5)
| `100% <100%> (ø)` | |
    | [python/proton/reactor.py](https://codecov.io/gh/apache/qpid-proton/pull/150/diff?src=pr&el=tree#diff-cHl0aG9uL3Byb3Rvbi9yZWFjdG9yLnB5)
| `73.54% <91.66%> (+2.67%)` | :arrow_up: |
    | [c/src/reactor/acceptor.c](https://codecov.io/gh/apache/qpid-proton/pull/150/diff?src=pr&el=tree#diff-Yy9zcmMvcmVhY3Rvci9hY2NlcHRvci5j)
| `96.61% <0%> (+11.86%)` | :arrow_up: |
    
    ------
    
    [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/150?src=pr&el=continue).
    > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
    > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
    > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/150?src=pr&el=footer).
Last update [252451f...b903c72](https://codecov.io/gh/apache/qpid-proton/pull/150?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



> Allow configuration of connection details via a simple config file
> ------------------------------------------------------------------
>
>                 Key: PROTON-1888
>                 URL: https://issues.apache.org/jira/browse/PROTON-1888
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: python-binding
>            Reporter: Gordon Sim
>            Priority: Major
>
> It can be convenient to keep details of the connection to be established out of application
code, making it easier to switch between environments. Support for a simple config file that
can be used to point the application at the right AMQP service would be useful. Ideally this
would be common across a range of clients.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message