qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From astitcher <...@git.apache.org>
Subject [GitHub] qpid-proton issue #157: WIP: extract connection_options_impl for tests and i...
Date Thu, 20 Sep 2018 19:07:01 GMT
Github user astitcher commented on the issue:

    https://github.com/apache/qpid-proton/pull/157
  
    Basically don't like this approach because it exposes implementation details to the library
interface.
    
    As the unit tests don't only need to be built in the build environment. Myself I'd be
happy with direct linking, but I'm not clear why you need/want to test the implementation
when the actual external interface pretty much directly passes through anyway.
    
    Perhaps you can give a simple example of a test that can't use the exposed API.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message