qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From astitcher <...@git.apache.org>
Subject [GitHub] qpid-proton issue #157: WIP: extract connection_options_impl for tests and i...
Date Fri, 21 Sep 2018 15:28:14 GMT
Github user astitcher commented on the issue:

    https://github.com/apache/qpid-proton/pull/157
  
    Honestly given the alternative, adding gets for the options seems fairly innocuous!
    
    To be (a little) less flippant Unit testing is actually a good reason to make the options
readable too. Although I'm not sure if this is a good idea for password though.
    
    I think the original reason for not making the options readable was that it was unecessary
as the client program should know what options it set, but unit testing is important too.
    
    Perhaps an alternative would be a "dump" method for the options (akin to ```pn_inspect()```
or __str__) which outputs the options in json for comparison although you'd have to parse
it and compare to be safe. But hey you've got a json parser linked in anyway!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message