qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alanconway <...@git.apache.org>
Subject [GitHub] qpid-proton issue #157: WIP: extract connection_options_impl for tests and i...
Date Fri, 21 Sep 2018 18:25:45 GMT
Github user alanconway commented on the issue:

    https://github.com/apache/qpid-proton/pull/157
  
    On Fri, Sep 21, 2018 at 11:28 AM Andrew Stitcher <notifications@github.com>
    wrote:
    
    > Honestly given the alternative, adding gets for the options seems fairly
    > innocuous!
    >
    > To be (a little) less flippant Unit testing is actually a good reason to
    > make the options readable too. Although I'm not sure if this is a good idea
    > for password though.
    >
    It shall be done.
    
    On password - proton overwrites the password memory once it's been written
    to the wire to void it hanging around in core dumps. Can we ever do this in
    options, or does reconnect rely on options holding on to the password? We
    could erase if reconnect is not enabled...
    
    > I think the original reason for not making the options readable was that
    > it was unecessary as the client program should know what options it set,
    > but unit testing is important too.
    >
    I have a proposal for making it useful to users too:
    void listen_handler::listen(listener&, connection_options&) {
       // examine incoming connection info - e.g. virtual_host
       // set further options for open response
    }



---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message