qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From astitcher <...@git.apache.org>
Subject [GitHub] qpid-proton pull request #159: PROTON-1940: [c] normalize encoding of multip...
Date Wed, 26 Sep 2018 14:38:02 GMT
Github user astitcher commented on a diff in the pull request:

    --- Diff: c/src/core/codec.c ---
    @@ -657,7 +657,46 @@ int pn_data_vfill(pn_data_t *data, const char *fmt, va_list ap)
    -    default:
    +     case 'M': {                /* multiple=true field value */
    +       /* Encode a pn_data_t * as a normalized multiple="true" field.
    +          See file:///home/aconway/specs/amqp-core-complete-v1.0.pdf
    --- End diff --
    What is 'multiple="true" field'? There is nothing called this in the standard is there?
The ="true' naming seems to indicate boolean fields, but this is not the case afaict - and
this really applies to a list of things that can also be empty in which case we just use null
instead of the empty list.
    Also url to local file system is not very helpful!


To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

View raw message