qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-7372) [Java Broker] Remove hard dependency on logback from broker-core
Date Tue, 25 Sep 2018 16:22:00 GMT

    [ https://issues.apache.org/jira/browse/QPID-7372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627587#comment-16627587
] 

ASF GitHub Bot commented on QPID-7372:
--------------------------------------

GitHub user yakuninv opened a pull request:

    https://github.com/apache/qpid-broker-j/pull/13

    QPID-7372, hasn't been fixed fully, there is still code dependency on logback

    Here we have hardcoded dependency on logback which makes broker fail to start when using
https://github.com/daknin/qpid-maven-plugin/, because maven uses org.slf4j.impl.SimpleLogger.
    
    Exception:
    Caused by: java.lang.ClassCastException: org.slf4j.impl.SimpleLogger cannot be cast to
ch.qos.logback.classic.Logger
    	at org.apache.qpid.server.Broker$1.run(Broker.java:147)
    	at java.security.AccessController.doPrivileged(Native Method)
    	at javax.security.auth.Subject.doAs(Subject.java:422)
    	at org.apache.qpid.server.Broker.startup(Broker.java:142)
    	at com.github.daknin.qpid.plugin.QpidBroker.start(QpidBroker.java:43)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yakuninv/qpid-broker-j patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-broker-j/pull/13.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13
    
----
commit 4758a06e269f05172ff5066b57abe344fbd6643a
Author: yakuninv <yakuninv@...>
Date:   2018-09-25T16:15:14Z

    Update Broker.java
    
    Here we have hardcoded dependency on logback which makes broker fail to start when using
https://github.com/daknin/qpid-maven-plugin/, because maven uses org.slf4j.impl.SimpleLogger.
    
    Exception:
    Caused by: java.lang.ClassCastException: org.slf4j.impl.SimpleLogger cannot be cast to
ch.qos.logback.classic.Logger
    	at org.apache.qpid.server.Broker$1.run(Broker.java:147)
    	at java.security.AccessController.doPrivileged(Native Method)
    	at javax.security.auth.Subject.doAs(Subject.java:422)
    	at org.apache.qpid.server.Broker.startup(Broker.java:142)
    	at com.github.daknin.qpid.plugin.QpidBroker.start(QpidBroker.java:43)

commit 097446ea55593d35d0c6d1bd0051ef12aa1a15d8
Author: yakuninv <yakuninv@...>
Date:   2018-09-25T16:17:26Z

    Update Broker.java

----


> [Java Broker] Remove hard dependency on logback from broker-core
> ----------------------------------------------------------------
>
>                 Key: QPID-7372
>                 URL: https://issues.apache.org/jira/browse/QPID-7372
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Broker-J
>            Reporter: Rob Godfrey
>            Assignee: Rob Godfrey
>            Priority: Major
>             Fix For: qpid-java-6.1
>
>
> Currently the SystemConfig class has a hard dependency on LogBack, and forces instantiation
/ resetting the logback config.
> To allow for easier embedding of the broker we can move this instantiation out of the
core model and into the code use to bootstrap the broker instance.  We can also move the logback
dependent model objects into a separate plugin.  In this way the System Config  (and child
Broker) will simply use whatever has been set up for them in slf4j and an embedder of the
broker could choose to use a different logging provider or supply a logback configuration
which is not managed by the broker itself.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message