qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robbie Gemmell (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (PROTON-1927) Python _reactor.py creates duplicate link names for senders/receivers
Date Tue, 11 Sep 2018 16:21:00 GMT

    [ https://issues.apache.org/jira/browse/PROTON-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610871#comment-16610871
] 

Robbie Gemmell edited comment on PROTON-1927 at 9/11/18 4:20 PM:
-----------------------------------------------------------------

Ok, so that avoids the issue of creating two different receivers over the wire with the same
name, but I'd say that is still a bug. If no name was given, and one is being generated, I
don't think it should be generating the same name and returning the same receiver again, but
rather a completely different name and returning an entirely new receiver.

So to summarise, creating a sender and receiver with the same generated name is OK, though
it would be nice to generate different ones (in qpid-jms we prefix the name with the use,
e.g receiver, sender, coordinator). The real bug though is in two different calls to create
a receiver (or similarly, sender?) generating the same name and returning the same receiver.


was (Author: gemmellr):
Ok, so that avoids the issue of creating two different receivers over the wire with the same
name, but I'd say that is still a bug. If no name was given, and one is being generated, I
don't think it should be generating the same name and returning the same reciever again, but
rather a completely different name and returning an entirely new receiver.

> Python _reactor.py creates duplicate link names for senders/receivers
> ---------------------------------------------------------------------
>
>                 Key: PROTON-1927
>                 URL: https://issues.apache.org/jira/browse/PROTON-1927
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: python-binding
>    Affects Versions: proton-c-0.24.0
>            Reporter: Chuck Rolke
>            Priority: Major
>
> From DISPATCH-1114
> Creating a sender and a receiver in the same container produces duplicate link names.
Try python/examples/helloworld.py that executes:
>         event.container.create_receiver(conn, self.address)
>         event.container.create_sender(conn, self.address)
> generates the same link name for each attach:
> (M=a1b7d *1 ?3) chug@ratchet examples> PN_TRACE_FRM=1 ./helloworld.py
> ...
> [0x55a01066d9a0]:0 -> @attach(18) [name="70ceeac8-50d8-4af2-9caf-20ef8700a7d3-examples",
handle=0, role=true, snd-settle-mode=2, rcv-settle-mode=0, source=@source(40) [address="examples",
durable=0, timeout=0, dynamic=false], target=@target(41) [durable=0, timeout=0, dynamic=false],
initial-delivery-count=0, max-message-size=0]
> [0x55a01066d9a0]:0 -> @attach(18) [name="70ceeac8-50d8-4af2-9caf-20ef8700a7d3-examples",
handle=1, role=false, snd-settle-mode=2, rcv-settle-mode=0, source=@source(40) [durable=0,
timeout=0, dynamic=false], target=@target(41) [address="examples", durable=0, timeout=0, dynamic=false],
initial-delivery-count=0, max-message-size=0]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message