qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DISPATCH-1117) doc on update logging with qdmanage is inaccurate
Date Thu, 06 Sep 2018 19:56:00 GMT

    [ https://issues.apache.org/jira/browse/DISPATCH-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606328#comment-16606328
] 

ASF GitHub Bot commented on DISPATCH-1117:
------------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/qpid-dispatch/pull/373
  
    # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/373?src=pr&el=h1) Report
    > Merging [#373](https://codecov.io/gh/apache/qpid-dispatch/pull/373?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/eb766e3ade97b4ee5bca0b21ebe7403a8317d6e9?src=pr&el=desc)
will **increase** coverage by `0.04%`.
    > The diff coverage is `n/a`.
    
    [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/373/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/373?src=pr&el=tree)
    
    ```diff
    @@            Coverage Diff             @@
    ##           master     #373      +/-   ##
    ==========================================
    + Coverage   84.79%   84.83%   +0.04%     
    ==========================================
      Files          70       70              
      Lines       16004    16002       -2     
    ==========================================
    + Hits        13570    13575       +5     
    + Misses       2434     2427       -7
    ```
    
    
    | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/373?src=pr&el=tree)
| Coverage Δ | |
    |---|---|---|
    | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/373/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==)
| `63.21% <0%> (-0.58%)` | :arrow_down: |
    | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/373/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j)
| `76.55% <0%> (-0.2%)` | :arrow_down: |
    | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/373/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==)
| `88.19% <0%> (+0.19%)` | :arrow_up: |
    | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/373/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `93.09% <0%> (+0.21%)` | :arrow_up: |
    | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/373/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.87% <0%> (+0.26%)` | :arrow_up: |
    | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/373/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `90.44% <0%> (+0.45%)` | :arrow_up: |
    
    ------
    
    [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/373?src=pr&el=continue).
    > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
    > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
    > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/373?src=pr&el=footer).
Last update [eb766e3...792dfa8](https://codecov.io/gh/apache/qpid-dispatch/pull/373?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



> doc on update logging with qdmanage is inaccurate
> -------------------------------------------------
>
>                 Key: DISPATCH-1117
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1117
>             Project: Qpid Dispatch
>          Issue Type: Bug
>            Reporter: Gordon Sim
>            Priority: Major
>             Fix For: 1.4.0
>
>
> (1) it shows examples using a 'create' operation which is not supported (and not needed)
> (2) it does not include name option for update which is required
> (3) it has '–' in front of attributes which is incorrect
> (4) it shows specifying the module on update which should not be recommended (see DISPATCH-1116)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message