qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alanconway <...@git.apache.org>
Subject [GitHub] qpid-proton pull request #159: PROTON-1940: [c] normalize encoding of multip...
Date Mon, 24 Sep 2018 20:08:31 GMT
GitHub user alanconway opened a pull request:

    https://github.com/apache/qpid-proton/pull/159

    PROTON-1940: [c] normalize encoding of multiple="true" fields

    AMQP spec allows several ways to encode a "multiple" field, we allow all in
    incoming data or pn_data_t values created in the user, but when writing
    to the wire we always encode:
    
    - empty array as null
    - single value array as a single value
    - multiple values - encoded as array
    
    This is the most compact encoding and seems to be best for interop, as some AMQP
    clients (.NET) have trouble with an empty array in a multiple value field.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alanconway/qpid-proton c-multiple-null

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-proton/pull/159.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #159
    
----
commit 51f4c581411a3295054323028faa59fdb56f4604
Author: Alan Conway <aconway@...>
Date:   2018-09-24T15:41:03Z

    PROTON-1940: [c] normalize encoding of multiple="true" fields
    
    AMQP spec allows several ways to encode a "multiple" field, we allow all in
    incoming data or pn_data_t values created in the user, but when writing
    to the wire we always encode:
    
    - empty array as null
    - single value array as a single value
    - multiple values - encoded as array
    
    This is the most compact encoding and seems to be best for interop, as some AMQP
    clients (.NET) have trouble with an empty array in a multiple value field.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message