qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Rudyy (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (QPID-7694) [Broker-J] Add 0-8..0-10 wire queue declare argument for holds on publish
Date Wed, 05 Dec 2018 14:09:00 GMT

    [ https://issues.apache.org/jira/browse/QPID-7694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710102#comment-16710102
] 

Alex Rudyy edited comment on QPID-7694 at 12/5/18 2:08 PM:
-----------------------------------------------------------

The changes committed in [c80aceab29fc8c6c835c0d83554286bbe2ed8e36|https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=c80aceab29fc8c6c835c0d83554286bbe2ed8e36],
[ab33d1ad69d3f27f8a56f046fd959ceb0f62d05a|https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=ab33d1a]
and [8bd6bd4206bc0855b162e0a2bbeb6c8db2fdda22|https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=8bd6bd4]
allow to specify any valid attribute in queue/exchange declare arguments. The unrecognized
argument names results in errors communicated back to client rather than being ignored as
Keith had suggested. I raised JIRA QPID-8263 to return the actual attributes as part of arguments
of QueueQueryResult and ExchangeQueryResult. We need either to change 0-10 codec to encode
correctly the attribute values of types {{java.util.Date}}, enums and {{ManagedAttributeValue}}
or make changes in {{ServerSessionDelegate}} to manually convert attribute values into types
currently supported  by 0-10 encoder.

I did not change the consumer subscription functionality to pass the consumer attributes as
part of arguments. If required, it can be done as part of separate JIRA. I am going to close
QPID-7694


was (Author: alex.rufous):
The changes committed in [ c80aceab29fc8c6c835c0d83554286bbe2ed8e36|https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=c80aceab29fc8c6c835c0d83554286bbe2ed8e36],
[ ab33d1ad69d3f27f8a56f046fd959ceb0f62d05a|https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=ab33d1a
] and [ 8bd6bd4206bc0855b162e0a2bbeb6c8db2fdda22|https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=8bd6bd4
] allow to specify any valid attribute in queue/exchange declare arguments. The unrecognized
argument names results in errors communicated back to client rather than being ignored as
Keith had suggested. I raised JIRA QPID-8263 to return the actual attributes as part of arguments
of QueueQueryResult and ExchangeQueryResult. We need either to change 0-10 codec to encode
correctly the attribute values of types {{java.util.Date}}, enums and {{ManagedAttributeValue}}
or make changes in {{ServerSessionDelegate}} to manually convert attribute values into types
currently supported  by 0-10 encoder.

I did not change the consumer subscription functionality to pass the consumer attributes as
part of arguments. If required, it can be done as part of separate JIRA. I am going to close
QPID-7694

> [Broker-J] Add 0-8..0-10 wire queue declare argument for holds on publish
> -------------------------------------------------------------------------
>
>                 Key: QPID-7694
>                 URL: https://issues.apache.org/jira/browse/QPID-7694
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Broker-J
>            Reporter: Keith Wall
>            Priority: Major
>             Fix For: qpid-java-broker-7.1.0
>
>
> From an ADDR address, I ought to be able to specify that the queue is declared with holdOnPublishEnabled
enabled.    Currently Queue#holdOnPublishEnabled is not mapped to a wire argument, so this
is not possible,



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message