qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DISPATCH-1213) Sender link sending pre-settled multi-frame deliveries can stall if receiver drops
Date Thu, 06 Dec 2018 20:21:00 GMT

    [ https://issues.apache.org/jira/browse/DISPATCH-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711987#comment-16711987
] 

ASF GitHub Bot commented on DISPATCH-1213:
------------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/qpid-dispatch/pull/425
  
    # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/425?src=pr&el=h1) Report
    > Merging [#425](https://codecov.io/gh/apache/qpid-dispatch/pull/425?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/2dde7030fb032a54fdefe5b7c5c4a39a4f1bfd6e?src=pr&el=desc)
will **decrease** coverage by `<.01%`.
    > The diff coverage is `100%`.
    
    [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/425/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/425?src=pr&el=tree)
    
    ```diff
    @@            Coverage Diff             @@
    ##           master     #425      +/-   ##
    ==========================================
    - Coverage   87.93%   87.92%   -0.01%     
    ==========================================
      Files          85       85              
      Lines       18236    18243       +7     
    ==========================================
    + Hits        16035    16041       +6     
    - Misses       2201     2202       +1
    ```
    
    
    | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/425?src=pr&el=tree)
| Coverage Δ | |
    |---|---|---|
    | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `91.28% <100%> (+0.38%)` | :arrow_up: |
    | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `94.21% <100%> (ø)` | :arrow_up: |
    | [src/router\_core/core\_timer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfdGltZXIuYw==)
| `94.64% <0%> (-1.79%)` | :arrow_down: |
    | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j)
| `77.01% <0%> (-0.77%)` | :arrow_down: |
    | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==)
| `63.27% <0%> (-0.57%)` | :arrow_down: |
    | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=)
| `88.04% <0%> (-0.26%)` | :arrow_down: |
    | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j)
| `76.36% <0%> (-0.25%)` | :arrow_down: |
    | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `95.2% <0%> (-0.13%)` | :arrow_down: |
    | [src/router\_core/modules/edge\_router/addr\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvYWRkcl9wcm94eS5j)
| `94.36% <0%> (+0.7%)` | :arrow_up: |
    | ... and [2 more](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr&el=tree-more)
| |
    
    ------
    
    [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/425?src=pr&el=continue).
    > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
    > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
    > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/425?src=pr&el=footer).
Last update [2dde703...e8124dc](https://codecov.io/gh/apache/qpid-dispatch/pull/425?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



> Sender  link  sending  pre-settled multi-frame deliveries can stall if receiver drops
 
> ---------------------------------------------------------------------------------------
>
>                 Key: DISPATCH-1213
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1213
>             Project: Qpid Dispatch
>          Issue Type: Bug
>          Components: Container
>    Affects Versions: 1.4.1
>            Reporter: Ganesh Murthy
>            Assignee: Ganesh Murthy
>            Priority: Major
>             Fix For: 1.5.0
>
>
> Steps to reproduce -
>  # Start the router
>  #  Start a receiver and receive 10 messages.
> {noformat}
> python simple_recv.py --address 0.0.0.0/examples -m10{noformat}
>  # Send 200 large presettled messages
> {noformat}
> python big_send_settled.py --address 0.0.0.0/examples -m200{noformat}
>  # Look at the output of qdstat -g
> {noformat}
> [gmurthy@localhost ~]$ qdstat -g
> Router Statistics
>   attr                             value
>   =============================================================
>   Version                          1.5.0-SNAPSHOT
>   Mode                             standalone
>   Router Id                        Standalone_lPF38hMqjGI_iAO
>   Area                             0
>   Link Routes                      0
>   Auto Links                       0
>   Links                            3
>   Nodes                            0
>   Addresses                        5
>   Connections                      2
>   Presettled Count                 17
>   Dropped Presettled Count         2
>   Accepted Count                   1
>   Rejected Count                   0
>   Released Count                   0
>   Modified Count                   0
>   Ingress Count                    19
>   Egress Count                     17
>   Transit Count                    0
>   Deliveries from Route Container  0
>   Deliveries to Route Container    0
> {noformat}
> The Ingress Count should be more than 200. We had all the credit we need to send 200
messages.
>  # The messages are stuck inside the proton buffer. The router stopped fetching the messages
from the proton buffer as soon as the q2_holdoff limit was hit.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message