qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DISPATCH-1231) Edge router fails to sync link routes due to credit stall
Date Mon, 24 Dec 2018 03:50:00 GMT

    [ https://issues.apache.org/jira/browse/DISPATCH-1231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728123#comment-16728123
] 

ASF GitHub Bot commented on DISPATCH-1231:
------------------------------------------

codecov-io commented on issue #431: DISPATCH-1231: correct credit handling in core client
URL: https://github.com/apache/qpid-dispatch/pull/431#issuecomment-449682539
 
 
   # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/431?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@b74263e`). [Click
here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `90%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/431/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/431?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master     #431   +/-   ##
   =========================================
     Coverage          ?   86.95%           
   =========================================
     Files             ?       85           
     Lines             ?    18682           
     Branches          ?        0           
   =========================================
     Hits              ?    16245           
     Misses            ?     2437           
     Partials          ?        0
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/431?src=pr&el=tree)
| Coverage Δ | |
   |---|---|---|
   | [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/431/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=)
| `85% <100%> (ø)` | |
   | [src/router\_core/core\_client\_api.c](https://codecov.io/gh/apache/qpid-dispatch/pull/431/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfY2xpZW50X2FwaS5j)
| `91.94% <100%> (ø)` | |
   | [...core/modules/address\_lookup\_client/lookup\_client.c](https://codecov.io/gh/apache/qpid-dispatch/pull/431/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvYWRkcmVzc19sb29rdXBfY2xpZW50L2xvb2t1cF9jbGllbnQuYw==)
| `92.19% <100%> (ø)` | |
   | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/431/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j)
| `79.28% <83.33%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/431?src=pr&el=footer).
Last update [b74263e...990c2a2](https://codecov.io/gh/apache/qpid-dispatch/pull/431?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Edge router fails to sync link routes due to credit stall
> ---------------------------------------------------------
>
>                 Key: DISPATCH-1231
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1231
>             Project: Qpid Dispatch
>          Issue Type: Bug
>          Components: Router Node
>    Affects Versions: 1.5.0
>            Reporter: Ken Giusti
>            Priority: Major
>
> core client code erroneously treats credit values as absolute where in fact the values
are additive.
> This will result in spurious hangs during the edge router link proxy tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message