qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-2040) [cpp] Allow connection options to be updated for automatic reconnect.
Date Fri, 03 May 2019 15:56:00 GMT

    [ https://issues.apache.org/jira/browse/PROTON-2040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832607#comment-16832607
] 

ASF GitHub Bot commented on PROTON-2040:
----------------------------------------

astitcher commented on issue #181: PROTON-2040 [cpp] Allow connection options to be updated
for reconnect
URL: https://github.com/apache/qpid-proton/pull/181#issuecomment-489144925
 
 
   > It's the pn_connection_t objects that effectively "remember" the options, along with
some of the internal C++ context objects. Probably I should add a test to prove this.
   
   I don't think this is the case exactly. Looking at the reconnect code (which I just did
to remind myself!) I see that we actually now do keep araound a copy of the `connection_options`
for a connection in the `connection_context`. This is there because at reconnect time you
actually have to get the failover urls and parameters from the connection options as they
aren't part of the underlying proton-c model at all. 
   
   Also looking at the reconnect code I see that at reconnect time it is the *cached away*
version of the options that is applied to the new transport of the new connection attempt
- I don't think your changes will affect the cached away version of the connection_options
- have you tested them?
   
   So I'm not convinced your changes even work - unless you've got a test to prove that they
do!
   
   In summary I think that my suggestion actually is feasible - provide an accessor to the
connections options - this would allow you to update them and then they would get used on
the next connection attempt.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> [cpp] Allow connection options to be updated for automatic reconnect.
> ---------------------------------------------------------------------
>
>                 Key: PROTON-2040
>                 URL: https://issues.apache.org/jira/browse/PROTON-2040
>             Project: Qpid Proton
>          Issue Type: New Feature
>          Components: cpp-binding
>    Affects Versions: proton-c-0.27.1
>            Reporter: Alan Conway
>            Assignee: Alan Conway
>            Priority: Major
>             Fix For: proton-c-0.28.0
>
>
> Allow modification of connection options prior to an automatic re-connect. Requested
on mailing list:
>  [https://lists.apache.org/thread.html/1fcd524de1e0d896a6f025470e0d774e051b8449dba0b9ddb3d0439e@%3Cusers.qpid.apache.org%3E]
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message