qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DISPATCH-1343) Faster qd_buffer and qd_message allocations
Date Fri, 24 May 2019 16:07:00 GMT

    [ https://issues.apache.org/jira/browse/DISPATCH-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847676#comment-16847676
] 

ASF GitHub Bot commented on DISPATCH-1343:
------------------------------------------

franz1981 commented on pull request #510: DISPATCH-1343 Faster qd_buffer and qd_message allocations
URL: https://github.com/apache/qpid-dispatch/pull/510#discussion_r287424668
 
 

 ##########
 File path: include/qpid/dispatch/atomic.h
 ##########
 @@ -203,6 +223,14 @@ static inline void sys_atomic_destroy(sys_atomic_t *ref)
     sys_mutex_free(ref->lock);
 }
 
+static inline void sys_atomic_release_fence()
+{
+    //it shoudn't leak any OS resources, because (unshared) spin locks
+    //are just user space atomic ints
+    sys_spinlock_t lock;
+    sys_spin_init(&lock);
 
 Review comment:
   This can be seen here: https://github.com/lattera/glibc/blob/895ef79e04a953cac1493863bcae29ad85657ee1/sysdeps/x86_64/nptl/pthread_spin_unlock.S#L22
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Faster qd_buffer and qd_message allocations
> -------------------------------------------
>
>                 Key: DISPATCH-1343
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1343
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>    Affects Versions: 1.7.0
>            Reporter: Francesco Nigro
>            Priority: Major
>
> qd_buffer and qd_message allocations are using heavyweight initialization mechanisms
for atomic ints fields, unnecessary for both atomicity and visibility purposes while allocating.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message