qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DISPATCH-1385) qd_message_list_t is dead code
Date Fri, 12 Jul 2019 17:08:01 GMT

    [ https://issues.apache.org/jira/browse/DISPATCH-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883991#comment-16883991
] 

ASF GitHub Bot commented on DISPATCH-1385:
------------------------------------------

codecov-io commented on issue #535: DISPATCH-1385 qd_message_list_t is dead code
URL: https://github.com/apache/qpid-dispatch/pull/535#issuecomment-510961833
 
 
   # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/535?src=pr&el=h1) Report
   > Merging [#535](https://codecov.io/gh/apache/qpid-dispatch/pull/535?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/f22766996be12f5a0d6b388d04be6d7ccad1eb80?src=pr&el=desc)
will **decrease** coverage by `0.07%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/535/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/535?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #535      +/-   ##
   ==========================================
   - Coverage   86.91%   86.83%   -0.08%     
   ==========================================
     Files          87       87              
     Lines       19521    19520       -1     
   ==========================================
   - Hits        16967    16951      -16     
   - Misses       2554     2569      +15
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/535?src=pr&el=tree)
| Coverage Δ | |
   |---|---|---|
   | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/535/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==)
| `88.77% <ø> (-0.03%)` | :arrow_down: |
   | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/535/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=)
| `84.76% <0%> (-1.64%)` | :arrow_down: |
   | [...c/router\_core/modules/test\_hooks/core\_test\_hooks.c](https://codecov.io/gh/apache/qpid-dispatch/pull/535/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvdGVzdF9ob29rcy9jb3JlX3Rlc3RfaG9va3MuYw==)
| `92.67% <0%> (-1.28%)` | :arrow_down: |
   | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/535/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `94.62% <0%> (-0.77%)` | :arrow_down: |
   | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/535/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.69% <0%> (-0.13%)` | :arrow_down: |
   | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/535/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `94.7% <0%> (-0.12%)` | :arrow_down: |
   | [src/router\_core/core\_client\_api.c](https://codecov.io/gh/apache/qpid-dispatch/pull/535/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfY2xpZW50X2FwaS5j)
| `91.94% <0%> (+0.36%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/535?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/535?src=pr&el=footer).
Last update [f227669...1b8a9ba](https://codecov.io/gh/apache/qpid-dispatch/pull/535?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> qd_message_list_t is dead code
> ------------------------------
>
>                 Key: DISPATCH-1385
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1385
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>          Components: Routing Engine
>    Affects Versions: 1.8.0
>            Reporter: Francesco Nigro
>            Priority: Trivial
>
> qd_message_list_t  is dead code and DEQ_LINKS(qd_message_t) can be removed by qd_message_t,
saving (potentially, depends on he mercy of the allocator while aligning on cache line during
allocation) 16 bytes on 64 bit machines for each allocated/pooled instance



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message