qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DISPATCH-1389) Optimize the parsing of message annotations
Date Mon, 22 Jul 2019 14:47:00 GMT

    [ https://issues.apache.org/jira/browse/DISPATCH-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890225#comment-16890225
] 

ASF GitHub Bot commented on DISPATCH-1389:
------------------------------------------

ganeshmurthy commented on pull request #541: DISPATCH-1389: optimize the STATE_IN_BODY codepath
in qd_iterator_octet
URL: https://github.com/apache/qpid-dispatch/pull/541#discussion_r305884459
 
 

 ##########
 File path: src/iterator.c
 ##########
 @@ -555,8 +555,33 @@ void qd_iterator_annotate_space(qd_iterator_t *iter, const char* space,
int spac
 
 unsigned char qd_iterator_octet(qd_iterator_t *iter)
 {
-    if (!iter)
-        return 0;
+    assert(iter);
 
 Review comment:
   It is good to add this assert but can we still keep this line ?
       if (!iter)
           return 0;
   
   It saves the router from a crash in production environment 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Optimize the parsing of message annotations
> -------------------------------------------
>
>                 Key: DISPATCH-1389
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1389
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>            Reporter: Ken Giusti
>            Assignee: Ken Giusti
>            Priority: Major
>
> Parsing message annotations, especially on the inter router incoming link, are quite
expensive.
> For example, in a simple standalone router test the time it takes on average (on my puny
laptop) to receive a message and hand it off to the core is ~1 usec:
> TestRouterA: link MyReceiver count=500000 rx=1.094 
> Compare that time to the same operation performed on the inbound router link on a two-hop
router configuration:
> TestRouterB: link MyReceiver count=500000 rx=7.035 
> On average it's 7x slower.  Most of this time appears to be spent manipulating inbound
message annotations.
>  
> This Jira tracks work towards improving the performance of message annotation processing.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message