qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DISPATCH-1389) Optimize the parsing of message annotations
Date Tue, 30 Jul 2019 13:17:00 GMT

    [ https://issues.apache.org/jira/browse/DISPATCH-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896122#comment-16896122
] 

ASF GitHub Bot commented on DISPATCH-1389:
------------------------------------------

codecov-io commented on issue #546: DISPATCH-1389: optimize qd_iterator_advance, qd_iterator_ncopy
and
URL: https://github.com/apache/qpid-dispatch/pull/546#issuecomment-516413915
 
 
   # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/546?src=pr&el=h1) Report
   > Merging [#546](https://codecov.io/gh/apache/qpid-dispatch/pull/546?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/7c67a39aaafc161f15071b1da0baf2a023252b07?src=pr&el=desc)
will **increase** coverage by `0.07%`.
   > The diff coverage is `97.65%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/546/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/546?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master    #546      +/-   ##
   =========================================
   + Coverage   86.53%   86.6%   +0.07%     
   =========================================
     Files          88      88              
     Lines       19640   19730      +90     
   =========================================
   + Hits        16995   17087      +92     
   + Misses       2645    2643       -2
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/546?src=pr&el=tree)
| Coverage Δ | |
   |---|---|---|
   | [tests/field\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/546/diff?src=pr&el=tree#diff-dGVzdHMvZmllbGRfdGVzdC5j)
| `79.56% <80%> (ø)` | :arrow_up: |
   | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/546/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=)
| `90.09% <99.15%> (+1.76%)` | :arrow_up: |
   | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/546/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=)
| `86.53% <0%> (-0.2%)` | :arrow_down: |
   | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/546/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=)
| `84.96% <0%> (+0.2%)` | :arrow_up: |
   | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/546/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `92.99% <0%> (+0.24%)` | :arrow_up: |
   | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/546/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `94.37% <0%> (+0.25%)` | :arrow_up: |
   | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/546/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==)
| `67.33% <0%> (+0.5%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/546?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/546?src=pr&el=footer).
Last update [7c67a39...d5aa45b](https://codecov.io/gh/apache/qpid-dispatch/pull/546?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Optimize the parsing of message annotations
> -------------------------------------------
>
>                 Key: DISPATCH-1389
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1389
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>            Reporter: Ken Giusti
>            Assignee: Ken Giusti
>            Priority: Major
>
> Parsing message annotations, especially on the inter router incoming link, are quite
expensive.
> For example, in a simple standalone router test the time it takes on average (on my puny
laptop) to receive a message and hand it off to the core is ~1 usec:
> TestRouterA: link MyReceiver count=500000 rx=1.094 
> Compare that time to the same operation performed on the inbound router link on a two-hop
router configuration:
> TestRouterB: link MyReceiver count=500000 rx=7.035 
> On average it's 7x slower.  Most of this time appears to be spent manipulating inbound
message annotations.
>  
> This Jira tracks work towards improving the performance of message annotation processing.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message