qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DISPATCH-1390) qd_buffer_list_clone is copying too much data
Date Mon, 22 Jul 2019 15:02:00 GMT

    [ https://issues.apache.org/jira/browse/DISPATCH-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890234#comment-16890234
] 

ASF GitHub Bot commented on DISPATCH-1390:
------------------------------------------

codecov-io commented on issue #543: DISPATCH-1390 - qd_buffer_list_clone is copying too much
data
URL: https://github.com/apache/qpid-dispatch/pull/543#issuecomment-513829677
 
 
   # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/543?src=pr&el=h1) Report
   > Merging [#543](https://codecov.io/gh/apache/qpid-dispatch/pull/543?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/ab665701376e34b0a1bc213010f902e778aa7028?src=pr&el=desc)
will **decrease** coverage by `0.02%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/543/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/543?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #543      +/-   ##
   ==========================================
   - Coverage   86.79%   86.76%   -0.03%     
   ==========================================
     Files          87       87              
     Lines       19641    19642       +1     
   ==========================================
   - Hits        17048    17043       -5     
   - Misses       2593     2599       +6
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/543?src=pr&el=tree)
| Coverage Δ | |
   |---|---|---|
   | [src/buffer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/543/diff?src=pr&el=tree#diff-c3JjL2J1ZmZlci5j)
| `95.52% <100%> (ø)` | :arrow_up: |
   | [tests/buffer\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/543/diff?src=pr&el=tree#diff-dGVzdHMvYnVmZmVyX3Rlc3QuYw==)
| `97.5% <100%> (+0.06%)` | :arrow_up: |
   | [src/router\_core/core\_client\_api.c](https://codecov.io/gh/apache/qpid-dispatch/pull/543/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfY2xpZW50X2FwaS5j)
| `90.84% <0%> (-1.1%)` | :arrow_down: |
   | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/543/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==)
| `67.83% <0%> (-0.51%)` | :arrow_down: |
   | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/543/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.45% <0%> (-0.37%)` | :arrow_down: |
   | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/543/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `94.37% <0%> (-0.26%)` | :arrow_down: |
   | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/543/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=)
| `86.53% <0%> (-0.2%)` | :arrow_down: |
   | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/543/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j)
| `79.44% <0%> (-0.19%)` | :arrow_down: |
   | [...re/modules/edge\_addr\_tracking/edge\_addr\_tracking.c](https://codecov.io/gh/apache/qpid-dispatch/pull/543/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9hZGRyX3RyYWNraW5nL2VkZ2VfYWRkcl90cmFja2luZy5j)
| `85.48% <0%> (+0.53%)` | :arrow_up: |
   | [...c/router\_core/modules/test\_hooks/core\_test\_hooks.c](https://codecov.io/gh/apache/qpid-dispatch/pull/543/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvdGVzdF9ob29rcy9jb3JlX3Rlc3RfaG9va3MuYw==)
| `93.63% <0%> (+0.95%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/543?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/543?src=pr&el=footer).
Last update [ab66570...86d653f](https://codecov.io/gh/apache/qpid-dispatch/pull/543?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> qd_buffer_list_clone is copying too much data
> ---------------------------------------------
>
>                 Key: DISPATCH-1390
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1390
>             Project: Qpid Dispatch
>          Issue Type: Bug
>            Reporter: Francesco Nigro
>            Priority: Major
>
> qd_buffer_list_clone is ignoring the size of the src buffer and always copy the entire
capacity
> of it into the destination buffer.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message