qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [qpid-broker-j] alex-rufous commented on a change in pull request #34: QPID-7615 Number of selectors can be equal to connection thread pool size
Date Thu, 12 Sep 2019 15:17:51 GMT
alex-rufous commented on a change in pull request #34: QPID-7615 Number of selectors can be
equal to connection thread pool size
URL: https://github.com/apache/qpid-broker-j/pull/34#discussion_r323796251
 
 

 ##########
 File path: broker-core/src/test/java/org/apache/qpid/server/model/VirtualHostTest.java
 ##########
 @@ -542,32 +558,50 @@ public void testCreateValidation()
     }
 
     @Test
-    public void testChangeValidation()
+    public void testSelectorNumberMustBePositiveOnChange()
     {
-        QueueManagingVirtualHost<?> virtualHost = createVirtualHost(getTestName());
+        final QueueManagingVirtualHost<?> virtualHost = createVirtualHost(getTestName());
+        virtualHost.setAttributes(Collections.singletonMap(QueueManagingVirtualHost.NUMBER_OF_SELECTORS,
"1"));
 
 Review comment:
   The test can be strengthen with asserts verifying that specified values are indeed  set
on the corresponding attributes

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message