qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [qpid-dispatch] gemmellr commented on a change in pull request #717: DISPATCH-975: Enforce max message size on message ingress
Date Wed, 15 Apr 2020 17:49:13 GMT
gemmellr commented on a change in pull request #717: DISPATCH-975: Enforce max message size
on message ingress
URL: https://github.com/apache/qpid-dispatch/pull/717#discussion_r409024595
 
 

 ##########
 File path: src/amqp.c
 ##########
 @@ -86,6 +86,7 @@ const char * const QD_AMQP_COND_RESOURCE_DELETED = "amqp:resource-deleted";
 const char * const QD_AMQP_COND_ILLEGAL_STATE = "amqp:illegal-state";
 const char * const QD_AMQP_COND_FRAME_SIZE_TOO_SMALL = "amqp:frame-size-too-small";
 const char * const QD_AMQP_COND_CONNECTION_FORCED = "amqp:connection:forced";
+const char * const QD_AMQP_COND_MESSAGE_SIZE_EXCEEDED = "amqp:connection:message-size-exceeded";
 
 Review comment:
   Its arguably not that big a deal to the sending client, as anyone sending over the limit
is going to have issues either way.
   
   I was more curious given the commentry seems to suggest inter-router connections could
be getting killed too in certain cases, which could affect other things besides the one doing
the send? Or is that not the case? Though I guess that effect may still be true of link closure
too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message