qpid-proton mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-445) Binding installation ignores prefix
Date Tue, 03 Dec 2013 20:40:40 GMT

    [ https://issues.apache.org/jira/browse/PROTON-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13838153#comment-13838153

ASF subversion and git services commented on PROTON-445:

Commit 1547578 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1547578 ]

PROTON-445: Perl install now honors CMAKE_INSTALL_PREFIX

The language bindings will now honor this prefix, both the default
value and a user-specified value.

Developers can override it, though, by specifying PERL_INSTALL_PREFIX
at the command line as well. This will allow for installing the Perl
bindings to a different directory if so desired.

Also updated the installation pieces in CMake to simplify it.

> Binding installation ignores prefix
> -----------------------------------
>                 Key: PROTON-445
>                 URL: https://issues.apache.org/jira/browse/PROTON-445
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: 0.5
>            Reporter: Justin Ross
>         Attachments: what-a-mess.txt
> It allows you *prepend* to the install prefix, but it gives you no way afaict to actually
change the prefix.
> This is the opposite of nice.  If you set a prefix for your build *and* you try to get
your bindings slotted in with them, via DESTDIR, you get this:
> # cmake -DCMAKE_INSTALL_PREFIX:PATH=/opt/myplace /var/tmp/jross/baker/proton/source
> # make install DESTDIR=/opt/myplace
> /opt/myplace/usr/lib/python/*python files*
> /opt/myplace/opt/myplace/lib/*c files*
> ^^ Note "/opt/myplace/opt/myplace", the first from DESTDIR, the second from CMAKE_INSTALL_PREFIX
> What it is doing now is simply abuse of DESTDIR.  DESTDIR is intended to be a mechanism
for staged installs (packaging systems use this), and it cannot function correctly as an override
for prefix.
> http://www.gnu.org/prep/standards/html_node/DESTDIR.html
> My proposed solution to this is to stop this madness: make the binding install honor
CMAKE_INSTALL_PREFIX.  Let the developer be responsible for choosing the right location for
his or her distribution.

This message was sent by Atlassian JIRA

View raw message