qpid-proton mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-516) [proton-c] Dispatcher frame buffer set to peer's max frame size.
Date Tue, 03 Jun 2014 20:44:02 GMT

    [ https://issues.apache.org/jira/browse/PROTON-516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017125#comment-14017125
] 

ASF subversion and git services commented on PROTON-516:
--------------------------------------------------------

Commit 1599791 from [~astitcher] in branch 'proton/trunk'
[ https://svn.apache.org/r1599791 ]

PROTON-516: Don't allocate a frame buffer the size of the remote max frame size

> [proton-c] Dispatcher frame buffer set to peer's max frame size.
> ----------------------------------------------------------------
>
>                 Key: PROTON-516
>                 URL: https://issues.apache.org/jira/browse/PROTON-516
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: 0.6
>            Reporter: Ken Giusti
>            Assignee: Andrew Stitcher
>             Fix For: 0.8
>
>
> The size of the output frame buffer used by the Transport is set unconditionally to the
max frame size advertised by the peer:
> In transport.c::int pn_do_open(pn_dispatcher_t *disp):
>    pn_buffer_ensure( disp->frame, disp->remote_max_frame );
> This can potentially exhaust memory on small memory systems (eg, embedded devices). 
Instead, the output frame buffer should grow as needed based on the size of the payloads generated,
limited by the remote_max_frame value.
> And, of course, pn_buffer_ensure + caller should handle realloc failures instead of ignoring
them.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message