qpid-proton mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-596) There is no equivalent to 'config.sh' for windows
Date Fri, 06 Jun 2014 20:55:02 GMT

    [ https://issues.apache.org/jira/browse/PROTON-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020354#comment-14020354
] 

ASF subversion and git services commented on PROTON-596:
--------------------------------------------------------

Commit 1601010 from chug@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1601010 ]

PROTON-596: Suppress MSVC warnings

This suppression covers:

>..\..\proton-c\src\object\object.c(232): 
   warning C4244: 'argument' : conversion from 'ssize_t' to 'int',
   possible loss of data
2>..\..\proton-c\src\object\object.c(260):
   warning C4267: 'argument' : conversion from 'size_t' to 'int',
   possible loss of data
2>..\..\proton-c\src\windows\driver.c(777):
   warning C4800: 'int' : forcing value to bool 'true' or 'false'
   (performance warning)
6>..\..\..\..\..\tests\tools\apps\c\msgr-recv.c(90): 
   warning C4996: 'sscanf': This function or variable may be unsafe.
   Consider using sscanf_s instead. 
   To disable deprecation, use _CRT_SECURE_NO_WARNINGS

This covers the majority of the warnings. A typical 64-bit compile has 172 
warnings making real problems harder to see. It also follows the
pattern used in Qpid proper.

* C4244 and C4267 could still be real problems.
  Try enabling -Wconversion in GCC if you want to be pedantic in Qpid or
  Proton.

* C4800 is probably not a risk as it's a fairly idiomatic pattern in C.

* C4996 is MSVC complaining of functions that consume buffers using
 {pointer} and not {pointer, size}. They have been the source of seg
 faults and innumerable security vulnerabilities throughout the years.

> There is no equivalent to 'config.sh' for windows
> -------------------------------------------------
>
>                 Key: PROTON-596
>                 URL: https://issues.apache.org/jira/browse/PROTON-596
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: 0.7
>         Environment: Proton on windows
>            Reporter: Chuck Rolke
>
> ctest fails to find compiled C tests. Some environment settings are needed in addition
to those supplied by cmake/ctest.
> Linux users have the luxury of config.sh to steer their environment correctly for tests
built in proton/build. Windows users need the same.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message