qpid-proton mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "michael goulish (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-625) Biggest Backtrace Ever!
Date Thu, 03 Jul 2014 02:48:25 GMT

    [ https://issues.apache.org/jira/browse/PROTON-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14051007#comment-14051007
] 

michael goulish commented on PROTON-625:
----------------------------------------

Here is a hack that fixes it.
A little new code in pni_map_ensure().

Tested this on latest protonics, version 1607485.

Without hack:  3 failures out of 10 tests. (similar to what I have been seeing on other versions.)

With hack:  0 failures out of 13 tests.  ( probability this happened by chance: less that
1% )


So, now I'm trying to see how it should *really* be fixed...


--- code --- code --- code --- code --- code --- code --- code --- code --- code ---


 // This loop is what is already there, in pni_map_ensure.  No change.
  while (map->capacity < capacity || pni_map_load(map) > map->load_factor) {
    map->capacity *= 2;
    map->addressable = (size_t) (0.86 * map->capacity);
  }

  /*---------------------------------------------------
    If ever we get past the above while-loop without 
    actually having changed map->cap, we are doomed 
    to eternal torment.  So, force it.
  ---------------------------------------------------*/
  if ( oldcap == map->capacity )
  {
    fprintf ( stderr, "Fiery the angels fell; deep thunder rolled around their shores, burning
with the fires of Orc!\n" );
    map->capacity *= 2;
    map->addressable = (size_t) (0.86 * map->capacity);
  }


> Biggest Backtrace Ever!
> -----------------------
>
>                 Key: PROTON-625
>                 URL: https://issues.apache.org/jira/browse/PROTON-625
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: 0.8
>            Reporter: michael goulish
>
> I am saving all my stuff so I can repro on demand.
> It doesn't happen every time, but it's about 50%.
> ------------------------------------------
> On one box, I have a dispatch router.
> On the other box, I have 10 clients: 5 Messenger-based receivers, and 5 qpid-messaging-based
senders.
> Each client will handle 100 addresses, of the form "mick/0" ... "mick/1" ... & c.
> 100 messages will be sent to each address.
> I start the 5 receivers first.  They start OK.  Dispatch router happy & stable.
> Wait a few seconds.
> I start the 5 senders, from a bash script.
> The first sender is already sending when the 2nd, 3rd, 4th start.
> After a few of them start,but before all have finished starting,  a few seconds into
the script, the crash occurs.  ( If they all start up successfully, no crash. )
> The crash occurs in the dispatch router.
> Here is the biggest backtrace ever:
> #0  0x0000003cf9879ad1 in _int_malloc (av=0x7f101c000020, bytes=16384) at malloc.c:4383
> #1  0x0000003cf987a911 in __libc_malloc (bytes=16384) at malloc.c:3664
> #2  0x00000039c6c1650a in pni_map_allocate () from /usr/lib64/libqpid-proton.so.2
> #3  0x00000039c6c16a3a in pni_map_ensure () from /usr/lib64/libqpid-proton.so.2
> #4  0x00000039c6c16c45 in pni_map_entry () from /usr/lib64/libqpid-proton.so.2
> #5  0x00000039c6c16c64 in pni_map_entry () from /usr/lib64/libqpid-proton.so.2
> #6  0x00000039c6c16c64 in pni_map_entry () from /usr/lib64/libqpid-proton.so.2
> #7  0x00000039c6c16c64 in pni_map_entry () from /usr/lib64/libqpid-proton.so.2
> #8  0x00000039c6c16c64 in pni_map_entry () from /usr/lib64/libqpid-proton.so.2
> #9  0x00000039c6c16c64 in pni_map_entry () from /usr/lib64/libqpid-proton.so.2
> #10 0x00000039c6c16c64 in pni_map_entry () from /usr/lib64/libqpid-proton.so.2
> #11 0x00000039c6c16c64 in pni_map_entry () from /usr/lib64/libqpid-proton.so.2
> #12 0x00000039c6c16c64 in pni_map_entry () from /usr/lib64/libqpid-proton.so.2
> #13 0x00000039c6c16c64 in pni_map_entry () from /usr/lib64/libqpid-proton.so.2
> #14 0x00000039c6c16c64 in pni_map_entry () from /usr/lib64/libqpid-proton.so.2
> .
> .
> .
> .
> #93549 0x00000039c6c16c64 in pni_map_entry () from /usr/lib64/libqpid-proton.so.2
> #93550 0x00000039c6c16c64 in pni_map_entry () from /usr/lib64/libqpid-proton.so.2
> #93551 0x00000039c6c16c64 in pni_map_entry () from /usr/lib64/libqpid-proton.so.2
> #93552 0x00000039c6c16c64 in pni_map_entry () from /usr/lib64/libqpid-proton.so.2
> #93553 0x00000039c6c16c64 in pni_map_entry () from /usr/lib64/libqpid-proton.so.2
> #93554 0x00000039c6c16c64 in pni_map_entry () from /usr/lib64/libqpid-proton.so.2
> #93555 0x00000039c6c16c64 in pni_map_entry () from /usr/lib64/libqpid-proton.so.2
> #93556 0x00000039c6c16c64 in pni_map_entry () from /usr/lib64/libqpid-proton.so.2
> #93557 0x00000039c6c16c64 in pni_map_entry () from /usr/lib64/libqpid-proton.so.2
> #93558 0x00000039c6c16c64 in pni_map_entry () from /usr/lib64/libqpid-proton.so.2
> #93559 0x00000039c6c16dc0 in pn_map_put () from /usr/lib64/libqpid-proton.so.2
> #93560 0x00000039c6c17226 in pn_hash_put () from /usr/lib64/libqpid-proton.so.2
> #93561 0x00000039c6c2a643 in pn_delivery_map_push () from /usr/lib64/libqpid-proton.so.2
> #93562 0x00000039c6c2c44b in pn_do_transfer () from /usr/lib64/libqpid-proton.so.2
> #93563 0x00000039c6c24385 in pn_dispatch_frame () from /usr/lib64/libqpid-proton.so.2
> #93564 0x00000039c6c2448f in pn_dispatcher_input () from /usr/lib64/libqpid-proton.so.2
> #93565 0x00000039c6c2d68b in pn_input_read_amqp () from /usr/lib64/libqpid-proton.so.2
> #93566 0x00000039c6c3011a in pn_io_layer_input_passthru () from /usr/lib64/libqpid-proton.so.2
> #93567 0x00000039c6c3011a in pn_io_layer_input_passthru () from /usr/lib64/libqpid-proton.so.2
> #93568 0x00000039c6c2d275 in transport_consume () from /usr/lib64/libqpid-proton.so.2
> #93569 0x00000039c6c304cd in pn_transport_process () from /usr/lib64/libqpid-proton.so.2
> #93570 0x00000039c6c3e40c in pn_connector_process () from /usr/lib64/libqpid-proton.so.2
> #93571 0x00007f1060c60460 in process_connector () from /home/mick/dispatch/build/libqpid-dispatch.so.0
> #93572 0x00007f1060c61017 in thread_run () from /home/mick/dispatch/build/libqpid-dispatch.so.0
> #93573 0x0000003cf9c07851 in start_thread (arg=0x7f1052bfd700) at pthread_create.c:301
> #93574 0x0000003cf98e890d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:115



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message