qpid-proton mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-770) Refactor Proton C to eliminate the pn_dispatcher_t class
Date Thu, 11 Dec 2014 04:13:13 GMT

    [ https://issues.apache.org/jira/browse/PROTON-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14242114#comment-14242114

ASF subversion and git services commented on PROTON-770:

Commit fc9b88eada8c685fb2a003570bf903a9360f48d2 in qpid-proton's branch refs/heads/master
from [~astitcher]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=fc9b88e ]

PROTON-770: Change dispatcher interface (more parameters for frame handlers)
- Use transport, frametype and channel
- Pass more of the frame directly into the frame handlers

> Refactor Proton C to eliminate the pn_dispatcher_t class
> --------------------------------------------------------
>                 Key: PROTON-770
>                 URL: https://issues.apache.org/jira/browse/PROTON-770
>             Project: Qpid Proton
>          Issue Type: Improvement
>            Reporter: Andrew Stitcher
>            Assignee: Andrew Stitcher
> The pn_dispatcher_t class has two intertwined purposes -
> * To hold some temporary and scratch data used for processing incoming and outgoing frames.
> * To dispatch incoming frames to frame handling code.
> It turns out that the first purpose is overhead: The temporary data can be better passed
as parameters to the code that is using it; The scratch data is duplicated and would be better
put in the associated pn_transport_t which is where is ends up going anyway.
> The second purpose turns out to boil down to 1 boolean and some code which can be handled
differently. The boolean is to tell the dispatcher to stop.

This message was sent by Atlassian JIRA

View raw message