qpid-proton mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-751) [PATCH] proton-c: pn_connect failures aren't exposed via messenger->error
Date Tue, 03 Feb 2015 21:45:35 GMT

    [ https://issues.apache.org/jira/browse/PROTON-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304068#comment-14304068
] 

ASF subversion and git services commented on PROTON-751:
--------------------------------------------------------

Commit b9423d462fa2faae8b18b223e543becf4c6850e3 in qpid-proton's branch refs/heads/master
from [~dnwe]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=b9423d4 ]

PROTON-751: if pn_connect fails copy io->error

Update pn_messenger_resolve to copy the error set on messenger->io to
messenger->error in the event that PN_INVALID_SOCKET is returned by the
pn_connect call (in the same way as we already do for pn_listener_ctx)


> [PATCH] proton-c: pn_connect failures aren't exposed via messenger->error
> -------------------------------------------------------------------------
>
>                 Key: PROTON-751
>                 URL: https://issues.apache.org/jira/browse/PROTON-751
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: 0.8
>            Reporter: Dominic Evans
>             Fix For: 0.9
>
>         Attachments: 0001-If-pn_connect-fails-copy-io-error-to-messenger.patch
>
>
> If I attempt to put and send a message using messenger to a unresolvable DNS name, messenger
just blocks indefinitely (or until timeout if one is set) and the getaddrinfo failure is never
exposed to the user via messenger->error
> ```
> e.g.,
> $ bundle exec ruby send.rb -a madeup.example.com
> ```
> The fix is to update pn_messenger_resolve to copy the error set on messenger->io to
messenger->error in the event that PN_INVALID_SOCKET is returned by the pn_connect call
(in the same way as we already do for pn_listener_ctx)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message