qpid-proton mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Stitcher (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-804) the transport doesn't always shutdown its output properly
Date Thu, 12 Feb 2015 17:53:11 GMT

    [ https://issues.apache.org/jira/browse/PROTON-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318629#comment-14318629
] 

Andrew Stitcher commented on PROTON-804:
----------------------------------------

Thanks for checking the fix.

It's really about making the tests robust in the face of a changing implementation, and easing
the developer burden as the implementation changes.

Currently The tests are badly commented and it's not clear from them whether what they test
is fundamental or just what the implementation does at the moment. This means a developer
(well me specifically) can spend a lot of time debugging failing tests only to realise that
the tested behaviour isn't actually important to maintain.

In this case I think the test should merely be that eventually the connection got closed by
both parties ignoring any further bytes sent.

> the transport doesn't always shutdown its output properly
> ---------------------------------------------------------
>
>                 Key: PROTON-804
>                 URL: https://issues.apache.org/jira/browse/PROTON-804
>             Project: Qpid Proton
>          Issue Type: Bug
>            Reporter: Rafael H. Schloming
>            Assignee: Andrew Stitcher
>         Attachments: 0001-This-may-be-a-fix-for-PROTON-804-on-error-in-server-.patch,
transport-test.patch
>
>
> I believe the issue is related to the autodetect code andrew added not too long ago.
I've attached a patch that has a test case with a relatively minimal reproducer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message