qpid-proton mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-576) proton-j: codec support for UTF-8 encoding and decoding appears broken?
Date Wed, 04 Mar 2015 17:57:05 GMT

    [ https://issues.apache.org/jira/browse/PROTON-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14347249#comment-14347249
] 

ASF GitHub Bot commented on PROTON-576:
---------------------------------------

Github user gemmellr commented on the pull request:

    https://github.com/apache/qpid-proton/pull/10#issuecomment-77209715
  
    I had a chat with Rob and he thought the change looked ok. Could you make a new JIRA though
and merge it against that, since PROTON-576 was already release in 0.8.


> proton-j: codec support for UTF-8 encoding and decoding appears broken?
> -----------------------------------------------------------------------
>
>                 Key: PROTON-576
>                 URL: https://issues.apache.org/jira/browse/PROTON-576
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-j
>    Affects Versions: 0.7
>            Reporter: Dominic Evans
>             Fix For: 0.8
>
>         Attachments: 02_fix_stringtype_encode_decode.patch, PROTON-576.patch
>
>
> It seems like Proton-J has its own custom UTF-8 encoder, but relies on Java String's
built-in UTF-8 decoder. However, the code doesn't seem quite right and complex double byte
UTF-8 like emoji ('📔🚢🍛🍴🍹🏊🏄') can quite easily fail to parse:
> |   |   Cause:1       :-  java.lang.IllegalArgumentException: Cannot parse String
> |   |   Message:1     :-  Cannot parse String
> |   |   StackTrace:1  :-  java.lang.IllegalArgumentException: Cannot parse String
> |   |   	at org.apache.qpid.proton.codec.StringType$1.decode(StringType.java:48)
> |   |   	at org.apache.qpid.proton.codec.StringType$1.decode(StringType.java:36)
> |   |   	at org.apache.qpid.proton.codec.DecoderImpl.readRaw(DecoderImpl.java:945)
> |   |   	at org.apache.qpid.proton.codec.StringType$AllStringEncoding.readValue(StringType.java:172)
> |   |   	at org.apache.qpid.proton.codec.StringType$AllStringEncoding.readValue(StringType.java:124)
> |   |   	at org.apache.qpid.proton.codec.DynamicTypeConstructor.readValue(DynamicTypeConstructor.java:39)
> |   |   	at org.apache.qpid.proton.codec.DecoderImpl.readObject(DecoderImpl.java:885)
> |   |   	at org.apache.qpid.proton.message.impl.MessageImpl.decode(MessageImpl.java:629)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message