qpid-proton mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dnwe <...@git.apache.org>
Subject [GitHub] qpid-proton pull request: PROTON-334: SASL Implementation for Prot...
Date Thu, 16 Apr 2015 08:21:56 GMT
Github user dnwe commented on the pull request:

    https://github.com/apache/qpid-proton/pull/17#issuecomment-93675959
  
    @astitcher minor issue, unrelated to the feature itself, but the CMake build doesn't currently
report which sasl implementation is being used. I just see:
    ```
    -- Looking for sasl_checkpass in sasl2
    -- Looking for sasl_checkpass in sasl2 - found
    -- Looking for include file sasl/sasl.h
    -- Looking for include file sasl/sasl.h - found
    -- Found SASL: 1  
    ```
    Could you perhaps add something along the lines of:
    ```
    if (FOUND_SASL_LIB)
      message(STATUS "Found SASL: ${FOUND_SASL_LIB}")
    else()
      message(STATUS "Found SASL: BUILT-IN")
    endif(FOUND_SASL_LIB)
    ```
      



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message