qpid-proton mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-844) proton-j: ArrayIndexOutOfBounds exception if remote peer sends a handle >1024
Date Thu, 02 Apr 2015 18:13:54 GMT

    [ https://issues.apache.org/jira/browse/PROTON-844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393073#comment-14393073
] 

ASF GitHub Bot commented on PROTON-844:
---------------------------------------

GitHub user dnwe opened a pull request:

    https://github.com/apache/qpid-proton/pull/16

    PROTON-844: police handle-max in proton-j

    * when receiving an attach with a handle > handle-max, the connection
      should be closed
    * when attempting to allocate a new local handle when handle-max are
      already in-use should throw an Exception
    * the default of 1024 handle-max is quite small when proton-c appears to
      default to 4294967295 - increase it more modestly to 65536
    
    Closes #16

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dnwe/qpid-proton fix-proton-844

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-proton/pull/16.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #16
    
----
commit f937ccd04a99575cb44ec4108908d155e9f3a101
Author: Dominic Evans <dominic.evans@uk.ibm.com>
Date:   2015-04-02T17:59:27Z

    PROTON-844: police handle-max in proton-j
    
    * when receiving an attach with a handle > handle-max, the connection
      should be closed
    * when attempting to allocate a new local handle when handle-max are
      already in-use should throw an Exception
    * the default of 1024 handle-max is quite small when proton-c appears to
      default to 4294967295 - increase it more modestly to 65536
    
    Closes #16

----


> proton-j: ArrayIndexOutOfBounds exception if remote peer sends a handle >1024
> -----------------------------------------------------------------------------
>
>                 Key: PROTON-844
>                 URL: https://issues.apache.org/jira/browse/PROTON-844
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-j
>    Affects Versions: 0.9
>            Reporter: Dominic Evans
>
> If a remote peer attempts to attach with a handle >1024, its advertised handle-max,
a proton-j service will hit an ArrayIndexOutOfBoundsException in the call to getLinkFromRemoteHandle
> Similarly, if a proton-j client attempts to allocate a local handle when all 1024 are
used up, it chooses UnsignedInteger.MAX_VALUE rather than throwing an Exception locally.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message