qpid-proton mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gemmellr <...@git.apache.org>
Subject [GitHub] qpid-proton pull request: PROTON-964: Proton-J extensible event ty...
Date Tue, 04 Aug 2015 10:19:29 GMT
Github user gemmellr commented on a diff in the pull request:

    https://github.com/apache/qpid-proton/pull/48#discussion_r36174376
  
    --- Diff: proton-j/src/main/java/org/apache/qpid/proton/engine/impl/EventImpl.java ---
    @@ -68,12 +69,19 @@ void clear()
         }
     
         @Override
    -    public Type getType()
    +    public EventType getEventType()
         {
             return type;
         }
     
         @Override
    +    public Type getType() {
    +        if (type instanceof Type)
    --- End diff --
    
    Braces on if statement.
    
    It would be nice if we didnt need to do an instanceof check, though I can only see making
all non-core events implement getType() fixing that... :/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message