qpid-proton mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gemmellr <...@git.apache.org>
Subject [GitHub] qpid-proton pull request: PROTON-964: Proton-J extensible event ty...
Date Tue, 04 Aug 2015 11:59:07 GMT
Github user gemmellr commented on a diff in the pull request:

    https://github.com/apache/qpid-proton/pull/48#discussion_r36179723
  
    --- Diff: proton-j/src/main/java/org/apache/qpid/proton/engine/Event.java ---
    @@ -80,15 +83,46 @@
             SELECTABLE_WRITABLE,
             SELECTABLE_EXPIRED,
             SELECTABLE_ERROR,
    -        SELECTABLE_FINAL
    +        SELECTABLE_FINAL,
    +        
    +        /**
    +         * This value must never be used to generate an event, it's only used as
    +         * a guard when casting custom EventTypes to builtin {@link Type} via
    +         * {@link Event#getBuiltinType()}.
    +         */
    +        NOT_A_BUILTIN_TYPE;
    --- End diff --
    
    That would also work yep.
    
    (I dislike needing to have it at all, but I can see why its there)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message