qpid-proton mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gemmellr <...@git.apache.org>
Subject [GitHub] qpid-proton pull request: PROTON-964: Proton-J extensible event ty...
Date Tue, 04 Aug 2015 12:25:31 GMT
Github user gemmellr commented on a diff in the pull request:

    https://github.com/apache/qpid-proton/pull/48#discussion_r36181543
  
    --- Diff: proton-j/src/main/java/org/apache/qpid/proton/engine/impl/EventImpl.java ---
    @@ -68,12 +69,19 @@ void clear()
         }
     
         @Override
    -    public Type getType()
    +    public EventType getEventType()
         {
             return type;
         }
     
         @Override
    +    public Type getType() {
    +        if (type instanceof Type)
    --- End diff --
    
    I'd be more inclined to drop the Reactor events from the Type given that there are currently
no users of those events yet (its never been released), whereas the others have been part
of the main API for using the engine for quite some time and changing them would definitely
hurt a bunch of folks. That said, my comment wasn't really about anything like that, just
noting a dislike of needing to do the instanceof but also recognising why :)
    
    I'm not sure about using 'Egnine'. I did actually think of that name earlier and decided
agaisnt suggesting it. I'd say the older events are 'more core' in some ways than the new
reactor ones, with the reactor being built on top of the eingine...but I guess also has IO
related events that dont. Having both 'engine' and 'reactor' events named Core right now seems
nicer in some ways than having the reactor events named 'Engine' events. I dunno. Mainly I
just disliked 'Builtin' :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message