qpid-proton mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bozzzzo <...@git.apache.org>
Subject [GitHub] qpid-proton pull request: PROTON-964: Proton-J extensible event ty...
Date Tue, 04 Aug 2015 13:24:24 GMT
Github user bozzzzo commented on a diff in the pull request:

    https://github.com/apache/qpid-proton/pull/48#discussion_r36186389
  
    --- Diff: proton-j/src/main/java/org/apache/qpid/proton/engine/impl/EventImpl.java ---
    @@ -68,12 +69,19 @@ void clear()
         }
     
         @Override
    -    public Type getType()
    +    public EventType getEventType()
         {
             return type;
         }
     
         @Override
    +    public Type getType() {
    +        if (type instanceof Type)
    --- End diff --
    
    > I'd be more inclined to drop the Reactor events from the Type given that there are
currently no users of those events yet (its never been released)
    
    If by drop you mean move reactor events to a future o.a.q.p.reactor.ReactorEvent.Type
then
    yes, that is exactly what I had in mind for a perfect world. It would be a code-massacre,
tho. Deleting them outright would be a mistake, they are useful, and used ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message