qpid-proton mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gemmellr <...@git.apache.org>
Subject [GitHub] qpid-proton pull request: PROTON-964: Proton-J extensible event ty...
Date Tue, 04 Aug 2015 13:51:09 GMT
Github user gemmellr commented on a diff in the pull request:

    https://github.com/apache/qpid-proton/pull/48#discussion_r36189359
  
    --- Diff: proton-j/src/main/java/org/apache/qpid/proton/engine/impl/EventImpl.java ---
    @@ -217,6 +101,19 @@ public void dispatch(Handler handler)
                 dispatch(children.next());
             }
         }
    +    
    +    @Override
    +    public void redispatch(EventType as_type, Handler handler) throws HandlerException

    --- End diff --
    
    Ok. Sounds like you might be using this in a slightly different way than I was thinking,
which is likely because I haven't actually used any of the reactor (or handler) stuff at all
yet :)
    
    It would be a good idea for some other folks to look this over who actually have, like
@rhs and @prestona.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message