qpid-proton mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bozzzzo <...@git.apache.org>
Subject [GitHub] qpid-proton pull request: PROTON-964: Proton-J extensible event ty...
Date Fri, 07 Aug 2015 14:17:20 GMT
Github user bozzzzo commented on a diff in the pull request:

    https://github.com/apache/qpid-proton/pull/48#discussion_r36522686
  
    --- Diff: proton-j/src/main/java/org/apache/qpid/proton/engine/impl/CollectorImpl.java
---
    @@ -57,9 +58,16 @@ public void pop()
             }
         }
     
    -    public EventImpl put(Event.Type type, Object context)
    +    public EventImpl put(EventType type, Object context)
         {
    -        if (tail != null && tail.getType() == type &&
    +        if (type == null) {
    +            throw new IllegalArgumentException("Type cannot be null");
    +        }
    +        if (!type.isValid()) {
    +            throw new IllegalArgumentException("Cannot put events of type " + type);
    +        }
    +        // XXX: @gemmellr points out that type equality is wrong for event de-duplication.
What about context equality?
    --- End diff --
    
    I can respin or drop the commit :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message