quetz-mod_python-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gregory (Grisha) Trubetskoy" <gri...@apache.org>
Subject Re: Fix for ConnectionDispatch
Date Fri, 28 Feb 2003 05:04:42 GMT

Ha ha - read this message right after tagging!

This is obviously a good fix of a simple bug, thanks for pointing it out.
I tested it and it seems to work, so I moved the release-3-0-2 tag, which
I think in this case is justified.

Grisha

On Tue, 25 Feb 2003, Chris Monson wrote:

> I have been playing with the lastest mod_python release and have
> discovered a bug in the ConnectionDispatch method in apache.py.
>
> The bug looks like a cut-n-paste error, with references to filter.dir
> and filter.name everywhere.  The latest CVS version of apache.py removes
> most but not all of these.  This does not normally pose a problem if the
> connection handling script is perfect.  However, if it is faulty and has
> parse or other errors, they will not show up in the error log as was
> intended.
>
> I have created a patch for the problem.  It is included below.
>
> I am just now beginning to work with mod_python, but I am well versed in
> both Python and Apache (usage and internals) and I am interested in
> helping out where I can.  Please let me know if I am going about this in
> the wrong way (e.g., I should not be posting to this list, you hate
> inlined patches, you already knew about this and are working on it
> thank-you-very-much, etc.).  :)
>
> mod_python-is-cool-ly yours,
> C
>
> Patch included here:
> *** apache.py    2003-02-25 16:16:58.000000000 -0700
> --- apache.py.new    2003-02-25 16:17:42.000000000 -0700
> ***************
> *** 160,168 ****
>               # Any other rerror (usually parsing)
>               try:
>                   exc_type, exc_value, exc_traceback = sys.exc_info()
> -                 filter.disable()
>                   result = self.ReportError(exc_type, exc_value,
> exc_traceback, srv=conn.base_server,
> !                                           phase=filter.name,
> hname=handler, debug=debug)
>               finally:
>                   exc_traceback = None
>
> --- 160,167 ----
>               # Any other rerror (usually parsing)
>               try:
>                   exc_type, exc_value, exc_traceback = sys.exc_info()
>                   result = self.ReportError(exc_type, exc_value,
> exc_traceback, srv=conn.base_server,
> !                                           phase="ConnectionHandler",
> hname=handler, debug=debug)
>               finally:
>                   exc_traceback = None
>
>


Mime
View raw message