quetz-mod_python-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Gallacher <jg.li...@sympatico.ca>
Subject Re: release? FileSession.py
Date Wed, 27 Apr 2005 18:01:33 GMT
Nicolas Lehuen wrote:
> Jim,
> Are you OK with this version of FileSession.py ? 

No, I moved beyond that version a while ago.

> I'm not sure I
> totally followed your thoughts since at a point the thread on
> FileSession became a bit blurry to me.

Hardly a suprise. It was getting kind of convoluted to me as well.

> If it's not OK, please send me
> a corrected version.

Attached is my latest and hopefully greatest. :)  This version uses the 
grace_period idea to avoid race and/or deadlock issues and correctly 
register the filesession_cleanup method to run at the end of a request.

In the original code there was a comment (from dharana?) about a random 
EOFError in the do_load method. I have not been able to reproduce this 
error but I left the comment in anyway.

Also, my comments for the filesession_cleanup function are rather 
verbose. Feel free to trim them as you see fit.


> Regards,
> Nicolas
> On 4/27/05, Jim Gallacher <jg.lists@sympatico.ca> wrote:
>>Gregory (Grisha) Trubetskoy wrote:
>>>What do you folks think about gearing up for a release? Meaning not
>>>adding new features and focusing on the little details (like docs,
>>>tests, bugs).
>>>The only major thing that I think needs to be finalized is FileSession -
>>>I'd like it to see all the locking issues resolved and either the code
>>>rolled in to Session.py or Session.py split into separate files by
>>>class, for consistency. I also think that if FileSession works well, it
>>>should be made the default session mechanism.
>>I think the last patch I submitted (2005-04-21) takes care of the
>>locking issues, but I don't think it's been committed yet. There is
>>still one small change I'd like to make in the do_load method, but other
>>than that I think the code is in good shape.
>>I like the idea of separate files for each class since it would make it
>>easy to add additional backends if there is such a desire in the future.
>>>Anything else major that I'm missing? I'd like to start a little
>>>discussion on what would be a reasonable timeline and start making baby
>>>steps towards achieving it.
>>I'll be away until Sunday, but should be able to put together some
>>documentation for FileSession and do some additional testing early next

View raw message