quetz-mod_python-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Graham Dumpleton (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MODPYTHON-131) Make name of mutex directory configurable.
Date Sat, 11 Mar 2006 04:49:40 GMT
    [ http://issues.apache.org/jira/browse/MODPYTHON-131?page=comments#action_12369959 ] 

Graham Dumpleton commented on MODPYTHON-131:
--------------------------------------------

In respect of:

  http://svn.apache.org/viewcvs/httpd/mod_python/trunk/src/include/mod_python.h.in?rev=385000&r1=384999&r2=385000&view=diff

I think you probably want:

/* MUTEX_DIR can be set as a configure option
 * ./configure --with-mutex-dir=/path/to/dir
 */
#define MUTEX_DIR "@MUTEX_DIR@"

Ie., quote value of macro.

And in:

  http://svn.apache.org/viewcvs/httpd/mod_python/trunk/src/mod_python.c?rev=385000&r1=384999&r2=385000&view=diff

you probably want:

        snprintf(fname, 255, "%s/mpmtx%d%d", MUTEX_DIR, glb->parent_pid, n);

Ie., MUTEX_DIR is substituted using %s, as macro will not be expanded in string.

Not sure why tests still pass with the way it was.



> Make name of mutex directory configurable.
> ------------------------------------------
>
>          Key: MODPYTHON-131
>          URL: http://issues.apache.org/jira/browse/MODPYTHON-131
>      Project: mod_python
>         Type: Improvement
>   Components: core
>     Versions: 3.2.7
>     Reporter: Graham Dumpleton
>     Assignee: Jim Gallacher

>
> Creating an issue for this so it can be tracked.
> Been pointed out in:
>   http://www.mail-archive.com/python-dev@httpd.apache.org/msg01271.html
> that on Mandriva Linux, that is is necessary to manually change the mutex directory in
mod_python.c source code. Area of code is:
>   #if !defined(OS2) && !defined(WIN32) && !defined(BEOS) && !defined(NETWARE)
>         char fname[255];
>         snprintf(fname, 255, "/tmp/mpmtx%d%d", glb->parent_pid, n);
>   #else
>         char *fname = NULL;
>   #endif
> There should be an option to configure program to allow this to be more easily changed.
> Way of changing the value through Apache configuration to also be investigated further.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message