quetz-mod_python-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gregory (Grisha) Trubetskoy" <gri...@apache.org>
Subject Re: [jira] Assigned: (MODPYTHON-59) Add get_session() method to request object
Date Mon, 13 Mar 2006 03:39:22 GMT

I'm -1 on get_session() too. The request object is supposed to be a 
representation of Apache's request, and get_session() just does not belong 
there.

Grisha

On Sun, 12 Mar 2006, Jim Gallacher wrote:

> I handn't really intended to start working on an implementation. I just don't 
> like seeing all those issues in JIRA marked as unassigned. :) Since I created 
> it I figured I should take some responsibility for it. Plus, it's a gentle 
> reminder when I list my assigned issues - resolve it one way or another.
>
> I still think we need some sort of solution to the problem of people trying 
> to create 2 session instances in the same request, but I agree that the 
> original concept of req.get_session() was not quite right.
>
> Jim
>
> Graham Dumpleton wrote:
>> I would rather we not go ahead with adding req.get_session() at
>> this time. At least not how it was envisaged to be done previously.
>> 
>> I'll come back with a bit of analysis after I review where we were
>> up to previously.
>> 
>> Graham
>> 
>> On 12/03/2006, at 8:47 AM, Jim Gallacher (JIRA) wrote:
>> 
>>>      [ http://issues.apache.org/jira/browse/MODPYTHON-59?page=all ]
>>> 
>>> Jim Gallacher reassigned MODPYTHON-59:
>>> --------------------------------------
>>> 
>>>     Assign To: Jim Gallacher
>>> 
>>>> Add get_session() method to request object
>>>> ------------------------------------------
>>>> 
>>>>          Key: MODPYTHON-59
>>>>          URL: http://issues.apache.org/jira/browse/MODPYTHON-59
>>>>      Project: mod_python
>>>>         Type: New Feature
>>>>   Components: session
>>>>     Versions: 3.1.4, 3.1.3, 3.2.7
>>>>  Environment: All
>>>>     Reporter: Jim Gallacher
>>>>     Assignee: Jim Gallacher
>>>>      Fix For: 3.3
>>>>  Attachments: Session.py.diff.txt
>>>> 
>>>> Users will get session instances by calling req.get_session(). If a 
>>>> session already exists it will be returned, otherwise a new session 
>>>> instance will be created. Session configuration will be handled using 
>>>> apache directives rather than within their code.
>>>> Using this scheme means only one session instance will be created per 
>>>> request, which will eliminate the deadlock problems many people 
>>>> experience. Also, using this scheme makes it possible for sessions to 
>>>> be properly handled within psp pages and across 
>>>> req.internal_redirect() calls.
>>>> Code will be commited to svn shortly.
>>> 
>>> 
>>> -- 
>>> This message is automatically generated by JIRA.
>>> -
>>> If you think it was sent incorrectly contact one of the administrators:
>>>    http://issues.apache.org/jira/secure/Administrators.jspa
>>> -
>>> For more information on JIRA, see:
>>>    http://www.atlassian.com/software/jira
>> 
>> 
>> 
>

Mime
View raw message