ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colm O hEigeartaigh <cohei...@apache.org>
Subject Review Request 51721: Invert authorization logic in RangerKafkaAuthorizer
Date Thu, 08 Sep 2016 10:54:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51721/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-1171
    https://issues.apache.org/jira/browse/RANGER-1171


Repository: ranger


Description
-------

Similar to RANGER-1095, the RangerKafkaAuthorizer has a boolean "returnValue" which defaults
to true. However, there is a catch clause which just logs an error, meaning that a RuntimeException
could result in successful authorization. Instead, the boolean should default to false.


Diffs
-----

  plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java
8ce8233 

Diff: https://reviews.apache.org/r/51721/diff/


Testing
-------


Thanks,

Colm O hEigeartaigh


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message