> On Sept. 26, 2016, 5:18 p.m., Abhay Kulkarni wrote:
> > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasHdfsResourceMapper.java, line 41
> > <https://reviews.apache.org/r/52230/diff/1/?file=1509621#file1509621line41>
> >
> >     Consider moving this and similar attribute in AtlasHiveResourceMapper to AtlasResourceMapper class.

'qualifiedName' is not a common attribute across Atlas entities. Hence I have it duplicated in Hive and HDFS types.


- Madhan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52230/#review150417
-----------------------------------------------------------


On Sept. 24, 2016, 12:56 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52230/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2016, 12:56 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1177
>     https://issues.apache.org/jira/browse/RANGER-1177
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Added AtlasHdfsResourceMapper class and registred it in AtlasResourceMapperUtil
> 
> 
> Diffs
> -----
> 
>   tagsync/pom.xml 0e3fb39 
>   tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasHdfsResourceMapper.java PRE-CREATION 
>   tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasHiveResourceMapper.java ca7b063 
>   tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasResourceMapper.java d47d052 
>   tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasResourceMapperUtil.java f05d814 
>   tagsync/src/test/java/org/apache/ranger/tagsync/process/TestHdfsResourceMapper.java PRE-CREATION 
>   tagsync/src/test/java/org/apache/ranger/tagsync/process/TestHiveResourceMapper.java PRE-CREATION 
>   tagsync/src/test/java/org/apache/ranger/tagsync/process/TestTagSynchronizer.java c644e0d 
> 
> Diff: https://reviews.apache.org/r/52230/diff/
> 
> 
> Testing
> -------
> 
> - added unit tests
> - verified with Atlas notifications for hdfs_path entities
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>