ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nitin Galave <nitin.gal...@gmail.com>
Subject Review Request 58946: Ranger UI : Audit Menu-> Admin tab diff view pop-up does not come up.
Date Wed, 03 May 2017 12:59:19 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and
Velmurugan Periasamy.

Summary (updated)

Ranger UI : Audit Menu-> Admin tab diff view pop-up does not come up.

Bugs: RANGER-1555

Repository: ranger

Description (updated)

In Ranger UI Audit Menu-> admin tab: diff view popup does not comp up for following scenario's

1. Service delete operation (delete any service and check diff view log for the same).
2. Hive policy update operation for access policy.
    Steps to reproduce:
    a.Create hive policy by selecting resource as a table.
    b.Then, update the policy by changing resource table to UDF. 
    c.Check diff view log in Audit Menu-> admin tab
And also fixed following cases:
- Diff view popup doesn’t show deny exception policy Items: when taged policy is created.
- Diff view popup doesn’t show row level filter policy items: when policy is deleted(the
same case happening for masking policy item).

Diffs (updated)

  security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java d4ab8d7 
  security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java 8d9776a

  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 64baf76 
  security-admin/src/main/webapp/scripts/views/reports/PlugableServiceDiffDetail.js 9ec7e91

  security-admin/src/main/webapp/styles/xa.css 6cda421 
  security-admin/src/main/webapp/templates/reports/KnoxPolicyOperationDiff_tmpl.html 3afe134

  security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDiff_tmpl.html 3018c84

  security-admin/src/main/webapp/templates/reports/PolicyDeleteOperationDiff_tmpl.html 1449b04

  security-admin/src/main/webapp/templates/reports/PolicyOperationDiff_tmpl.html 54248f0 
  security-admin/src/main/webapp/templates/reports/PolicyUpdateOperationDiff_tmpl.html 38de921

Diff: https://reviews.apache.org/r/58946/diff/1/

Testing (updated)

Testing Done:

1. Verified diff view for CRUD operation for following modules: Service, Policy (Access, Masking,
Row level filter), User/Group.
2. Verified diff view popup for existing policies (for eg. Customers existing policies) for
CRUD operation logs.


Nitin Galave

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message